Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Add height: 100% to page content #19

Closed
teddybradford opened this issue Aug 16, 2017 · 6 comments
Closed

Add height: 100% to page content #19

teddybradford opened this issue Aug 16, 2017 · 6 comments

Comments

@teddybradford
Copy link
Contributor

teddybradford commented Aug 16, 2017

Add the following CSS so that we can do alignment inside pages.

.📖-content,
.📖-continuation,
.📖-continues {
  height: 100%;
}

Then we can do things like this:

.credits-page {
  display: flex;
  flex-direction: column;
  justify-content: flex-end;
  height: 100%;
}

which will align text to the bottom of a page.

I tried adding the 📖 CSS classes myself, but bindery threw a bunch of errors.

@evnbr
Copy link
Owner

evnbr commented Aug 16, 2017

yeah that breaks literally everything. bindery works by measuring those elements so they cannot have set heights.

the easiest solution would be to use fullbleedpage for this use case, if you want to access the whole height of the page.

or you could add all the content as footnotes, since those add from the bottom up. :P

if you think this is a common use case there could be a real way to set bottom alignment

@teddybradford
Copy link
Contributor Author

Ah, okay. I think using fullbleedpage could work for this, then.

@evnbr
Copy link
Owner

evnbr commented Aug 16, 2017

My original idea with FullPage was to have bleed optional. so if { bleed: true}, 100% is the full height with bleeds. and when { bleed: false }, 100% is just the height of the content area (within the margin).

would that be better? I imagine the credits page should have the same margin.

@evnbr evnbr reopened this Aug 16, 2017
@teddybradford
Copy link
Contributor Author

teddybradford commented Aug 16, 2017

That would actually be really nice.

Tangential question: Is the bleed size configurable? The default seems to be 20px, but could be nice to have an option for it. I missed it in the docs if it is already there.

@evnbr
Copy link
Owner

evnbr commented Aug 16, 2017

uhh it's configurable in the 'Marks and bleed' UI but not in the configuration options, my bad.

@evnbr
Copy link
Owner

evnbr commented Aug 16, 2017

Closing this in favor of #21 and #22

@evnbr evnbr closed this as completed Aug 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants