Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the OSX-specific platform code to ObjectiveC++ #13

Open
Duckwhale opened this issue May 30, 2023 · 1 comment
Open

Port the OSX-specific platform code to ObjectiveC++ #13

Duckwhale opened this issue May 30, 2023 · 1 comment

Comments

@Duckwhale
Copy link
Member

No more wild pointer casting and insane runtime crashes. This is a necessity to actually fix some of the more serious issues, such as the library crashing when multiple windows are created due to failing to reuse a shared app delegate.

@Duckwhale
Copy link
Member Author

The first big hurdle here is that the header-only library must be split because ObjectiveC "contaminates" every compilation unit it touches. Then, here's an entangled web of interdependence, particularly in the Windows platform code (custom WebView2Loader etc.) that. This makes separating the platform-specific code needlessly challenging, as it's referencing the "deprecated" and somewhat questionable JSON RPC functionality and the nondescript detail namespace in general.

All that to say, in the current form the library's code isn't conducive to this kind of sweeping change. Therefore, this is blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: It's finally happening! (WIP)
Development

No branches or pull requests

1 participant