Latest Embroider Issues

[evoactivity]

The latest release of embroider no longer works with my previous PR #238

We'll need to upgrade @embroider/test-setup to see the test failuers.

Not sure how reverting the change will affect people on older versions of Embroider.

I'm opening this issue to discuss and track the work needed.

context: https://discord.com/channels/480462759797063690/568935504288940056/1126880945455235092

• Upgrade @embroider/test-setup
• Revert Embroider #238
• Update asset inlining strategy
• No dynamic imports/requires

---

PR #252

[evoactivity]

@void-mAlex added additional context on discord

---

the embroider fix would be to use the importSync syntax instead of require I think
the move to app only breaks a few expectations on the part of the addon like the presence of the file in the addon folder
a lot of these things just happened to work in classic builds for various reasons but they are not compatible with modern build tooling
https://github.com/embroider-build/embroider/blob/main/packages/macros/README.md#importsync

[evoactivity]

So to sum up the changes made

• Update related dependencies
• Bump node version in workflows to 16 so fastboot recognises nullish coalescing operator
• Output an object of functions keyed by the asset id as an index.js inside the inlinded dir
• Import the generated index.js as an es module in the helper
• Look up the assetId function and run it to import the related svg
• Added test to ensure files with apostophes work

Other improvements to infra that could be made:

• Now that ember-release, canary and beta are on v5 might be worthwhile adding try scenarios for v4 LTS releases.
• The symbol injector seems flaky in tests, I added a waitFor with a 10 second timeout but it still times out randomly.
• Running ember try locally sometimes works and sometimes complains about @glimmer/validator being missing

but these can be done in another issue/pr.