Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation #17

Open
calclavia opened this issue Aug 2, 2016 · 2 comments
Open

Improve documentation #17

calclavia opened this issue Aug 2, 2016 · 2 comments

Comments

@calclavia
Copy link

There are several things I encountered when installing this native module that I would've appreciated if it was documented. Feel free to add these to the README.

  1. For iOS, simply placing the generated JSON file from Google into the iOS directory is insufficient. http://stackoverflow.com/questions/31294380/unable-to-find-googleservice-info-plist-while-trying-to-integrate-google-sign
  2. For Android, applying the Google play services Gradle plugin should've been done at the bottom of the Gradle file.
  3. For Android, I had to add new FIRAnalyticsPackage() in the getPackages() method in MainApplication.java.
@KendraTang
Copy link

Just note that for point 3, you would have to add
import com.evollu.react.fa.FIRAnalyticsPackage;
in MainApplication.java too.

@sibelius
Copy link

sibelius commented Dec 8, 2016

@calclavia could u please send a PR to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants