Add exclusive list and select list #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsmccrumb
commented
Jan 6, 2017
| @@ -153,7 +155,7 @@ $.widget( 'evol.structFilter', { | |||
| that._field=that._getFieldById(fieldID); | |||
| var fType=that._type=that._field.type; | |||
| that._setEditorOperator(); | |||
| if(fType==fTypes.list || fType==fTypes.bool){ | |||
| if([fTypes.list, fTypes.bool, fTypes.exList, fTypes.selList].indexOf(fType) > -1){ | |||
There was a problem hiding this comment.
Alternatively could be (here and 177):
if(fType==fTypes.list || fType==fTypes.bool || fType==fTypes.exList || fType==fTypes.selList){}though I think array is more succinct and easier to maintain?
jsmccrumb
commented
Jan 6, 2017
| @@ -339,6 +341,8 @@ $.widget( 'evol.structFilter', { | |||
| h+=EvoUI.inputHidden('operator',evoAPI.sInList); | |||
| this._operator=evoAPI.sInList; | |||
| break; | |||
| case fTypes.exList: | |||
| case fTypes.selList: | |||
There was a problem hiding this comment.
exclusive list and select list follow the same operator rule as boolean (equal)
|
Thanks. I like the feature idea. It not fully working yet. I'm looking at it. |
|
Excellent, thanks! If there is anything in particular I can do to help just let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented a version of select and exclusive lists (based on description in the issues I opened). Works fine on my end but I don't know your code too well and since its not a particularly minor change, it is possible that I broke something in the process.