Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampling type behaviour not contemplated #1

Open
saraiva132 opened this issue Sep 25, 2019 · 3 comments
Open

Sampling type behaviour not contemplated #1

saraiva132 opened this issue Sep 25, 2019 · 3 comments

Comments

@saraiva132
Copy link
Contributor

Sampling types have expected behaviour associated with it. They are still not contemplated. For instance, debug sampling should always report (potentially overriding even the enabled flag ?)

@t3hnar
Copy link
Contributor

t3hnar commented Sep 26, 2019

Does this answer your question ?
https://github.com/openzipkin/b3-propagation#sampling-state

@saraiva132
Copy link
Contributor Author

I was asking exactly because I read that documentation. Maybe I misunderstood. If we pass sampling property it is zipkin's that will actually act upon it? Based on the sampling in the TraceContext

@t3hnar
Copy link
Contributor

t3hnar commented Sep 26, 2019

@saraiva132 it will be handled by stracer in the future. It is not implemented yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants