-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django 1.7 compatibility and SchemedHttpResponseRedirect #186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
List of the schemes used by the Application `redirect_uris`
HttpResponseRedirect is very restrictive on the "safe" schemes: HTTP, HTTPS, FTP. As such, it does not allow redirections to custom schemes such as mobile callback handlers eg. `my-app://oauth/callback/` It was replaced with CustomSchemesHttpResponseRedirect that takes a list of allowed schemes.
Do not merge! The monkey patching is completely broken for tests. I'll update this PR ASAP to address the issue. Well, I did not notice there were two other PR and one issue for the "redirect" issue.
|
Okay let's do this the proper way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two things:
my-app-callback://oauth/
. This PR adds aSchemedHttpResponseRedirect
that allows all the schemes extracted fromredirect_uris
. As such, it remains safe.The code has been live-tested but there are no unit tests yet.
Feel free to make comments I you want me to change things.