Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android plugin code update for new JS API #14

Closed
ghost opened this issue Feb 4, 2014 · 4 comments
Closed

Android plugin code update for new JS API #14

ghost opened this issue Feb 4, 2014 · 4 comments

Comments

@ghost
Copy link

ghost commented Feb 4, 2014

The JavaScript API has changed, and the Android plugin needs updating.

Summary of changes:

  • Functions services, characteristics, and descriptors new return a list of found objects to the callback function.
  • Fields "serviceCount" and "characteristicCount" in object Service have been removed.
  • Field "descriptorCount" in object Characteristic has been removed.
  • Field "device" in ConnectInfo changed name to "deviceHandle".

There is a test program in file tests/test.html that can be used to verify that the plugins work consistently on Android and iOS.

@fredrikeldh
Copy link
Contributor

It's "deviceHandle", not "deviceInfo".

@fredrikeldh
Copy link
Contributor

My fork now contains a test-merge of your work. Does it look reasonable to you?
https://github.com/fredrikeldh/cordova-ble/commits/master
You may also want to see this commit on an off-branch:
fredrikeldh@6340c29
IIRC, Android has a known limit of maximum 4 connections per app lifetime, which limits our tests.

@ghost
Copy link
Author

ghost commented Feb 5, 2014

Thanks a lot for the review!
Changed "devieInfo" to "deviceHandle" (also in the info in the pull request).
Great that the scanRecord not available on iOS is documented, and updates to the test and everything looks great.
We can discuss further what to do with the close function.

@ghost
Copy link
Author

ghost commented Feb 28, 2014

Can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant