'haproxy_keepalived_internal_vip_cidr' is undefined

[odyssey4me]

As seen in http://logs.openstack.org/27/383927/1/gate/gate-openstack-ansible-openstack-ansible-aio-ubuntu-trusty/c07c0a4/console.html#_2016-10-10_02_25_32_475971 it looks like there could be better fencing for the variables used to resolve the deprecation warnings.

2016-10-10 02:25:32.475971 | TASK [keepalived : Dropping the general notification scripts (instances)] ******
2016-10-10 02:25:32.490222 | [DEPRECATION WARNING]: Skipping task due to undefined Error, in the future this
2016-10-10 02:25:32.490260 |  will be a fatal error.: {u'internal': {u'vips': [u'{{ 
2016-10-10 02:25:32.490278 | haproxy_keepalived_internal_vip_cidr }} dev {{ 
2016-10-10 02:25:32.490299 | haproxy_keepalived_internal_interface | default(management_bridge) }}'], 
2016-10-10 02:25:32.490319 | u'track_scripts': [u'haproxy_check_script', u'pingable_check_script'], 
2016-10-10 02:25:32.490332 | u'priority': u'{{ ((play_hosts|length-
2016-10-10 02:25:32.490389 | play_hosts.index(inventory_hostname))*100)-((play_hosts|length-
2016-10-10 02:25:32.490410 | play_hosts.index(inventory_hostname))*50) }}', u'state': u"{{ 
2016-10-10 02:25:32.490431 | (play_hosts.index(inventory_hostname) == 0) | ternary('MASTER', 'BACKUP') }}", 
2016-10-10 02:25:32.490453 | u'authentication_password': u'{{ haproxy_keepalived_authentication_password 
2016-10-10 02:25:32.490474 | }}', u'virtual_router_id': u"{{ haproxy_keepalived_internal_virtual_router_id |
2016-10-10 02:25:32.490495 |  default ('11') }}", u'interface': u'{{ haproxy_keepalived_internal_interface |
2016-10-10 02:25:32.490513 |  default(management_bridge) }}'}, u'external': {u'vips': [u'{{ 
2016-10-10 02:25:32.490528 | haproxy_keepalived_external_vip_cidr }} dev {{ 
2016-10-10 02:25:32.490548 | haproxy_keepalived_external_interface | default(management_bridge) }}'], 
2016-10-10 02:25:32.490568 | u'track_scripts': [u'haproxy_check_script', u'pingable_check_script'], 
2016-10-10 02:25:32.490581 | u'priority': u'{{ ((play_hosts|length-
2016-10-10 02:25:32.490599 | play_hosts.index(inventory_hostname))*100)-((play_hosts|length-
2016-10-10 02:25:32.490616 | play_hosts.index(inventory_hostname))*50) }}', u'state': u"{{ 
2016-10-10 02:25:32.490637 | (play_hosts.index(inventory_hostname) == 0) | ternary('MASTER', 'BACKUP') }}", 
2016-10-10 02:25:32.490671 | u'authentication_password': u'{{ haproxy_keepalived_authentication_password 
2016-10-10 02:25:32.490694 | }}', u'virtual_router_id': u"{{ haproxy_keepalived_external_virtual_router_id |
2016-10-10 02:25:32.490715 |  default ('10') }}", u'interface': u'{{ haproxy_keepalived_external_interface |
2016-10-10 02:25:32.490736 |  default(management_bridge) }}'}}: 'haproxy_keepalived_internal_vip_cidr' is 
2016-10-10 02:25:32.490743 | undefined.
2016-10-10 02:25:32.490761 | This feature will be removed in a future release. Deprecation 
2016-10-10 02:25:32.490782 | warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
2016-10-10 02:25:32.505323 | skipping: [aio1]
2016-10-10 02:25:32.519873 | 
2016-10-10 02:25:32.519922 | TASK [keepalived : Dropping the notification scripts for switching to master (instances)] ***
2016-10-10 02:25:32.531888 | [DEPRECATION WARNING]: Skipping task due to undefined Error, in the future this
2016-10-10 02:25:32.531936 |  will be a fatal error.: {u'internal': {u'vips': [u'{{ 
2016-10-10 02:25:32.531954 | haproxy_keepalived_internal_vip_cidr }} dev {{ 
2016-10-10 02:25:32.531975 | haproxy_keepalived_internal_interface | default(management_bridge) }}'], 
2016-10-10 02:25:32.531995 | u'track_scripts': [u'haproxy_check_script', u'pingable_check_script'], 
2016-10-10 02:25:32.532008 | u'priority': u'{{ ((play_hosts|length-
2016-10-10 02:25:32.532027 | play_hosts.index(inventory_hostname))*100)-((play_hosts|length-
2016-10-10 02:25:32.532046 | play_hosts.index(inventory_hostname))*50) }}', u'state': u"{{ 
2016-10-10 02:25:32.532067 | (play_hosts.index(inventory_hostname) == 0) | ternary('MASTER', 'BACKUP') }}", 
2016-10-10 02:25:32.532089 | u'authentication_password': u'{{ haproxy_keepalived_authentication_password 
2016-10-10 02:25:32.532110 | }}', u'virtual_router_id': u"{{ haproxy_keepalived_internal_virtual_router_id |
2016-10-10 02:25:32.532131 |  default ('11') }}", u'interface': u'{{ haproxy_keepalived_internal_interface |
2016-10-10 02:25:32.532150 |  default(management_bridge) }}'}, u'external': {u'vips': [u'{{ 
2016-10-10 02:25:32.532164 | haproxy_keepalived_external_vip_cidr }} dev {{ 
2016-10-10 02:25:32.532184 | haproxy_keepalived_external_interface | default(management_bridge) }}'], 
2016-10-10 02:25:32.532216 | u'track_scripts': [u'haproxy_check_script', u'pingable_check_script'], 
2016-10-10 02:25:32.532230 | u'priority': u'{{ ((play_hosts|length-
2016-10-10 02:25:32.532248 | play_hosts.index(inventory_hostname))*100)-((play_hosts|length-
2016-10-10 02:25:32.532267 | play_hosts.index(inventory_hostname))*50) }}', u'state': u"{{ 
2016-10-10 02:25:32.532289 | (play_hosts.index(inventory_hostname) == 0) | ternary('MASTER', 'BACKUP') }}", 
2016-10-10 02:25:32.532310 | u'authentication_password': u'{{ haproxy_keepalived_authentication_password 
2016-10-10 02:25:32.532332 | }}', u'virtual_router_id': u"{{ haproxy_keepalived_external_virtual_router_id |
2016-10-10 02:25:32.532354 |  default ('10') }}", u'interface': u'{{ haproxy_keepalived_external_interface |
2016-10-10 02:25:32.532376 |  default(management_bridge) }}'}}: 'haproxy_keepalived_internal_vip_cidr' is 
2016-10-10 02:25:32.532383 | undefined.
2016-10-10 02:25:32.532402 | This feature will be removed in a future release. Deprecation 
2016-10-10 02:25:32.532424 | warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
2016-10-10 02:25:32.549992 | skipping: [aio1]
2016-10-10 02:25:32.560731 | 
2016-10-10 02:25:32.560772 | TASK [keepalived : Dropping the notification scripts for switching to backup (instances)] ***
2016-10-10 02:25:32.573563 | [DEPRECATION WARNING]: Skipping task due to undefined Error, in the future this
2016-10-10 02:25:32.573599 |  will be a fatal error.: {u'internal': {u'vips': [u'{{ 
2016-10-10 02:25:32.573615 | haproxy_keepalived_internal_vip_cidr }} dev {{ 
2016-10-10 02:25:32.573634 | haproxy_keepalived_internal_interface | default(management_bridge) }}'], 
2016-10-10 02:25:32.573661 | u'track_scripts': [u'haproxy_check_script', u'pingable_check_script'], 
2016-10-10 02:25:32.573674 | u'priority': u'{{ ((play_hosts|length-
2016-10-10 02:25:32.573692 | play_hosts.index(inventory_hostname))*100)-((play_hosts|length-
2016-10-10 02:25:32.573709 | play_hosts.index(inventory_hostname))*50) }}', u'state': u"{{ 
2016-10-10 02:25:32.573729 | (play_hosts.index(inventory_hostname) == 0) | ternary('MASTER', 'BACKUP') }}", 
2016-10-10 02:25:32.573748 | u'authentication_password': u'{{ haproxy_keepalived_authentication_password 
2016-10-10 02:25:32.573768 | }}', u'virtual_router_id': u"{{ haproxy_keepalived_internal_virtual_router_id |
2016-10-10 02:25:32.573788 |  default ('11') }}", u'interface': u'{{ haproxy_keepalived_internal_interface |
2016-10-10 02:25:32.573805 |  default(management_bridge) }}'}, u'external': {u'vips': [u'{{ 
2016-10-10 02:25:32.573819 | haproxy_keepalived_external_vip_cidr }} dev {{ 
2016-10-10 02:25:32.573838 | haproxy_keepalived_external_interface | default(management_bridge) }}'], 
2016-10-10 02:25:32.573856 | u'track_scripts': [u'haproxy_check_script', u'pingable_check_script'], 
2016-10-10 02:25:32.573868 | u'priority': u'{{ ((play_hosts|length-
2016-10-10 02:25:32.573885 | play_hosts.index(inventory_hostname))*100)-((play_hosts|length-
2016-10-10 02:25:32.573902 | play_hosts.index(inventory_hostname))*50) }}', u'state': u"{{ 
2016-10-10 02:25:32.573922 | (play_hosts.index(inventory_hostname) == 0) | ternary('MASTER', 'BACKUP') }}", 
2016-10-10 02:25:32.573941 | u'authentication_password': u'{{ haproxy_keepalived_authentication_password 
2016-10-10 02:25:32.573961 | }}', u'virtual_router_id': u"{{ haproxy_keepalived_external_virtual_router_id |
2016-10-10 02:25:32.573981 |  default ('10') }}", u'interface': u'{{ haproxy_keepalived_external_interface |
2016-10-10 02:25:32.574001 |  default(management_bridge) }}'}}: 'haproxy_keepalived_internal_vip_cidr' is 
2016-10-10 02:25:32.574008 | undefined.
2016-10-10 02:25:32.574025 | This feature will be removed in a future release. Deprecation 
2016-10-10 02:25:32.574045 | warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
2016-10-10 02:25:32.587136 | skipping: [aio1]
2016-10-10 02:25:32.599938 | 
2016-10-10 02:25:32.599979 | TASK [keepalived : Dropping the notification scripts for stopping vrrp (instances)] ***
2016-10-10 02:25:32.612090 | [DEPRECATION WARNING]: Skipping task due to undefined Error, in the future this
2016-10-10 02:25:32.612127 |  will be a fatal error.: {u'internal': {u'vips': [u'{{ 
2016-10-10 02:25:32.612144 | haproxy_keepalived_internal_vip_cidr }} dev {{ 
2016-10-10 02:25:32.612165 | haproxy_keepalived_internal_interface | default(management_bridge) }}'], 
2016-10-10 02:25:32.612185 | u'track_scripts': [u'haproxy_check_script', u'pingable_check_script'], 
2016-10-10 02:25:32.612198 | u'priority': u'{{ ((play_hosts|length-
2016-10-10 02:25:32.612217 | play_hosts.index(inventory_hostname))*100)-((play_hosts|length-
2016-10-10 02:25:32.612235 | play_hosts.index(inventory_hostname))*50) }}', u'state': u"{{ 
2016-10-10 02:25:32.612256 | (play_hosts.index(inventory_hostname) == 0) | ternary('MASTER', 'BACKUP') }}", 
2016-10-10 02:25:32.612289 | u'authentication_password': u'{{ haproxy_keepalived_authentication_password 
2016-10-10 02:25:32.612311 | }}', u'virtual_router_id': u"{{ haproxy_keepalived_internal_virtual_router_id |
2016-10-10 02:25:32.612333 |  default ('11') }}", u'interface': u'{{ haproxy_keepalived_internal_interface |
2016-10-10 02:25:32.612352 |  default(management_bridge) }}'}, u'external': {u'vips': [u'{{ 
2016-10-10 02:25:32.612368 | haproxy_keepalived_external_vip_cidr }} dev {{ 
2016-10-10 02:25:32.612388 | haproxy_keepalived_external_interface | default(management_bridge) }}'], 
2016-10-10 02:25:32.612409 | u'track_scripts': [u'haproxy_check_script', u'pingable_check_script'], 
2016-10-10 02:25:32.612422 | u'priority': u'{{ ((play_hosts|length-
2016-10-10 02:25:32.612441 | play_hosts.index(inventory_hostname))*100)-((play_hosts|length-
2016-10-10 02:25:32.612469 | play_hosts.index(inventory_hostname))*50) }}', u'state': u"{{ 
2016-10-10 02:25:32.612492 | (play_hosts.index(inventory_hostname) == 0) | ternary('MASTER', 'BACKUP') }}", 
2016-10-10 02:25:32.612513 | u'authentication_password': u'{{ haproxy_keepalived_authentication_password 
2016-10-10 02:25:32.612535 | }}', u'virtual_router_id': u"{{ haproxy_keepalived_external_virtual_router_id |
2016-10-10 02:25:32.612557 |  default ('10') }}", u'interface': u'{{ haproxy_keepalived_external_interface |
2016-10-10 02:25:32.612578 |  default(management_bridge) }}'}}: 'haproxy_keepalived_internal_vip_cidr' is 
2016-10-10 02:25:32.612596 | undefined.
2016-10-10 02:25:32.612614 | This feature will be removed in a future release. Deprecation 
2016-10-10 02:25:32.612635 | warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
2016-10-10 02:25:32.625601 | skipping: [aio1]
2016-10-10 02:25:32.638430 | 
2016-10-10 02:25:32.638472 | TASK [keepalived : Dropping the notification scripts for failures (instances)] *
2016-10-10 02:25:32.650444 | [DEPRECATION WARNING]: Skipping task due to undefined Error, in the future this
2016-10-10 02:25:32.650481 |  will be a fatal error.: {u'internal': {u'vips': [u'{{ 
2016-10-10 02:25:32.650498 | haproxy_keepalived_internal_vip_cidr }} dev {{ 
2016-10-10 02:25:32.650519 | haproxy_keepalived_internal_interface | default(management_bridge) }}'], 
2016-10-10 02:25:32.650538 | u'track_scripts': [u'haproxy_check_script', u'pingable_check_script'], 
2016-10-10 02:25:32.650552 | u'priority': u'{{ ((play_hosts|length-
2016-10-10 02:25:32.650571 | play_hosts.index(inventory_hostname))*100)-((play_hosts|length-
2016-10-10 02:25:32.650589 | play_hosts.index(inventory_hostname))*50) }}', u'state': u"{{ 
2016-10-10 02:25:32.650610 | (play_hosts.index(inventory_hostname) == 0) | ternary('MASTER', 'BACKUP') }}", 
2016-10-10 02:25:32.650631 | u'authentication_password': u'{{ haproxy_keepalived_authentication_password 
2016-10-10 02:25:32.650652 | }}', u'virtual_router_id': u"{{ haproxy_keepalived_internal_virtual_router_id |
2016-10-10 02:25:32.650674 |  default ('11') }}", u'interface': u'{{ haproxy_keepalived_internal_interface |
2016-10-10 02:25:32.650692 |  default(management_bridge) }}'}, u'external': {u'vips': [u'{{ 
2016-10-10 02:25:32.650707 | haproxy_keepalived_external_vip_cidr }} dev {{ 
2016-10-10 02:25:32.650727 | haproxy_keepalived_external_interface | default(management_bridge) }}'], 
2016-10-10 02:25:32.650746 | u'track_scripts': [u'haproxy_check_script', u'pingable_check_script'], 
2016-10-10 02:25:32.650759 | u'priority': u'{{ ((play_hosts|length-
2016-10-10 02:25:32.650777 | play_hosts.index(inventory_hostname))*100)-((play_hosts|length-
2016-10-10 02:25:32.650795 | play_hosts.index(inventory_hostname))*50) }}', u'state': u"{{ 
2016-10-10 02:25:32.650816 | (play_hosts.index(inventory_hostname) == 0) | ternary('MASTER', 'BACKUP') }}", 
2016-10-10 02:25:32.650837 | u'authentication_password': u'{{ haproxy_keepalived_authentication_password 
2016-10-10 02:25:32.650858 | }}', u'virtual_router_id': u"{{ haproxy_keepalived_external_virtual_router_id |
2016-10-10 02:25:32.650879 |  default ('10') }}", u'interface': u'{{ haproxy_keepalived_external_interface |
2016-10-10 02:25:32.650900 |  default(management_bridge) }}'}}: 'haproxy_keepalived_internal_vip_cidr' is 
2016-10-10 02:25:32.650908 | undefined.
2016-10-10 02:25:32.650925 | This feature will be removed in a future release. Deprecation 
2016-10-10 02:25:32.650947 | warnings can be disabled by setting deprecation_warnings=False in ansible.cfg.
2016-10-10 02:25:32.668635 | skipping: [aio1]

[evrardjp]

Thanks for the bug submission.

I doubt this is a problem here. The required variables are explained on the README and haven't changed. When a mandatory variable is undefined, the role should fail.

The only reason to change something here would be our example file which has traces of an undefined variable inside a mandatory variable.

This issue should be fixed in openstack-ansible directly.