fix(Builder): fix fixMacMeta for later NW.js versions

evshiron · Apr 21, 2017 · a4d0563 · a4d0563
1 parent 724472e
commit a4d0563
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/src/lib/Builder.ts b/src/lib/Builder.ts
@@ -224,9 +224,13 @@ export class Builder {
 
             const path = resolve(targetDir, file);
 
-            const strings = <string>(await readFileAsync(path, {
-                encoding: 'ucs2',
-            }));
+            // Different versions has different encodings for `InforPlist.strings`.
+            // We determine encoding by evaluating bytes of `CF` here.
+            const data = await readFileAsync(path);
+            const encoding = data.indexOf(Buffer.from('43004600', 'hex')) >= 0
+            ? 'ucs2' : 'utf-8';
+
+            const strings = data.toString(encoding);
 
             const newStrings = strings.replace(/([A-Za-z]+)\s+=\s+"(.+?)";/g, (match: string, key: string, value: string) => {
                 switch(key) {
@@ -245,7 +249,7 @@ export class Builder {
                 }
             });
 
-            await writeFileAsync(path, Buffer.from(newStrings, 'ucs2'));
+            await writeFileAsync(path, Buffer.from(newStrings, encoding));
 
         }