Skip to content
This repository has been archived by the owner on Feb 22, 2020. It is now read-only.

Starting with 0.22.0 package for macOS is more than double the size #30

Closed
arudnev opened this issue Apr 24, 2017 · 6 comments
Closed

Comments

@arudnev
Copy link

arudnev commented Apr 24, 2017

It seems that in 0.22 NW.js changed what is included in the download for macOS, switching to symbolic links for some of the nested folders.

Before 0.22 this is what you normally would have in the nwjs package (actual folders with content).
screenshot 2017-04-24 12 46 12

In 0.22 instead of some of the folders that it used to have now it has symbolic links.
screenshot 2017-04-24 12 45 29

In the package for the app we end up having triple of original content.
screenshot 2017-04-24 12 44 38

One copy ends up in "nwjs Framework.framework", and two more copies in "nwjs Framework.framework/Versions/Current" and "nwjs Framework.framework/Versions/A" (the original content for this distro).

@evshiron
Copy link
Owner

nwjs-builder-phoenix started to dereference symlinks when I started using lerna, which automatically creates symlinks between packages, and the test for building wouldn't work without doing it.

I don't like symlinks at all and avoid using it especially in distribution, so I post an issue on nwjs/nw.js#5873 and wait for the answer.

If it's expected for later versions of NW.js, I am going copy NW.js while keeping the symlinks unchanged, and then copy project files with dereferenced symlinks. But these symlinks should fail someone who want to build macOS apps from Windows.

@evshiron
Copy link
Owner

If you are interested, commenting out this line should work (try finding the corresponding line in ./node_modules/nwjs-builder-phoenix/dist/lib/Builder.js).

@arudnev
Copy link
Author

arudnev commented Apr 24, 2017

When I discovered the issue last week I added extra step in our build process to remove content of "${name}.app/Contents/Versions/${version}/nwjs Framework.framework/Versions" after nwjs-builder-phoenix is done and before we run appdmg to create images, that way we don't have any symlinks or duplicates in our distro.
I think I'll wait for response to the ticket about intent of that change in NW.js distro and if that's here to stay then I'll test how it works without dereferencing. Or maybe some logic can be added to skip "**/nwjs Framework.framework/Versions" as part of the mentioned copy operation.

@evshiron
Copy link
Owner

According to @rogerwang, it's an intended change. I am preparing for an update for this.

@evshiron
Copy link
Owner

Hopefully this will be fixed in nwjs-builder-phoenix 1.10.2, please report back when you have time. I am having a slow Internet connection at the moment and can't test for it completely.

@arudnev
Copy link
Author

arudnev commented Apr 27, 2017

Thank you, seems to be all fine now. I was trying to test it yesterday, but was hitting issues with signature verification after install of the package downloaded from internet, wanted to make sure that signing issues were not related to use of symlinks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants