-
Notifications
You must be signed in to change notification settings - Fork 78
Starting with 0.22.0 package for macOS is more than double the size #30
Comments
I don't like symlinks at all and avoid using it especially in distribution, so I post an issue on nwjs/nw.js#5873 and wait for the answer. If it's expected for later versions of NW.js, I am going copy NW.js while keeping the symlinks unchanged, and then copy project files with dereferenced symlinks. But these symlinks should fail someone who want to build macOS apps from Windows. |
If you are interested, commenting out this line should work (try finding the corresponding line in |
When I discovered the issue last week I added extra step in our build process to remove content of "${name}.app/Contents/Versions/${version}/nwjs Framework.framework/Versions" after nwjs-builder-phoenix is done and before we run appdmg to create images, that way we don't have any symlinks or duplicates in our distro. |
According to @rogerwang, it's an intended change. I am preparing for an update for this. |
Hopefully this will be fixed in |
Thank you, seems to be all fine now. I was trying to test it yesterday, but was hitting issues with signature verification after install of the package downloaded from internet, wanted to make sure that signing issues were not related to use of symlinks. |
It seems that in 0.22 NW.js changed what is included in the download for macOS, switching to symbolic links for some of the nested folders.
Before 0.22 this is what you normally would have in the nwjs package (actual folders with content).
![screenshot 2017-04-24 12 46 12](https://cloud.githubusercontent.com/assets/1192686/25348614/c6411c88-28ec-11e7-9d02-591ab1d77597.png)
In 0.22 instead of some of the folders that it used to have now it has symbolic links.
![screenshot 2017-04-24 12 45 29](https://cloud.githubusercontent.com/assets/1192686/25348763/523f4b7e-28ed-11e7-8953-4ae5ef3c22e1.png)
In the package for the app we end up having triple of original content.
![screenshot 2017-04-24 12 44 38](https://cloud.githubusercontent.com/assets/1192686/25348863/a25f5504-28ed-11e7-93b9-1f0eb83834fd.png)
One copy ends up in "nwjs Framework.framework", and two more copies in "nwjs Framework.framework/Versions/Current" and "nwjs Framework.framework/Versions/A" (the original content for this distro).
The text was updated successfully, but these errors were encountered: