Skip to content
This repository has been archived by the owner on Jan 5, 2019. It is now read-only.

Endianness issue in bswap_m256 #203

Open
lrettig opened this issue Mar 22, 2018 · 2 comments
Open

Endianness issue in bswap_m256 #203

lrettig opened this issue Mar 22, 2018 · 2 comments

Comments

@lrettig
Copy link
Member

lrettig commented Mar 22, 2018

Logging this to track the conversation yesterday in gitter:

@axic Mar 21 18:38 very likely evm2was has endianess issues
@hugo-dc Mar 21 18:52 i’ve just confirmed storage is the problem, fill the tests expecting "0x" : “0x0200000000000000000000000000000000000000000000000000000000000000” in storage, and the test case pass
@jwasinger Mar 21 19:19 I have the fix. the endianness is being flipped by bswap_m256 : ;; generated by ./wasm/generateInterface.js\n(func $SSTORE (call $storageStore(call $bswap_m256 (get_global $sp))(call $bswap_m256 (i32.add (get_global $sp) (i32.const -32)))))

@lrettig
Copy link
Member Author

lrettig commented Apr 23, 2018

@jwasinger are we sure all the endianness issues are fixed already?

@jwasinger
Copy link
Contributor

jwasinger commented Apr 23, 2018

No, this was auto-closed by #202 which was merged 'as-is' (without fully fixing this issue)

@jwasinger jwasinger reopened this Apr 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants