Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up "features" #58

Closed
axic opened this issue May 28, 2019 · 2 comments
Closed

Cleaning up "features" #58

axic opened this issue May 28, 2019 · 2 comments
Labels
help wanted Extra attention is needed
Projects

Comments

@axic
Copy link
Member

axic commented May 28, 2019

Right now we have:

  • std/no_std
  • wee_alloc/qimalloc/stdalloc
  • one feature for each optional EEI: debug, experimental, bignum, eth2 (these would be merged into master once stable)

This is spawning this build hell as seen in #56.

Perhaps bignum could go under experimental. With time as these features mature, they wouldn't need to be conditionally enabled.

Maybe debug doesn't even need to be a feature, just made available. Idea by @jakelang to only enable the debug module when compiling in debug mode. Extending on that: how about making them macros which are compiled to nop in release mode?

@jakelang
Copy link
Member

We don't necessarily need to make them macros, but this is a nice idea because we can completely remove the code at compile-time rather than have calls to stub functions.

@axic axic mentioned this issue May 28, 2019
@axic axic added the help wanted Extra attention is needed label May 28, 2019
@axic axic added this to To do in 0.10 via automation May 28, 2019
@axic
Copy link
Member Author

axic commented May 29, 2019

We've already remove the "bignum" feature and created #63 to track the "debug" feature.

It seems we'll end up with:

  • std/not_std
  • (option to use other allocators)
  • "experimental" and "eth2" features

I think this is more manageable now.

@axic axic closed this as completed May 29, 2019
0.10 automation moved this from To do to Done May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
No open projects
0.10
  
Done
Development

No branches or pull requests

2 participants