Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy the sentinel-governance contract on the testnet #98

Open
axic opened this issue Nov 12, 2018 · 12 comments
Open

Deploy the sentinel-governance contract on the testnet #98

axic opened this issue Nov 12, 2018 · 12 comments

Comments

@axic
Copy link
Member

axic commented Nov 12, 2018

https://github.com/ewasm/sentinel-governance

  • Make sure to have truffle 5.x installed: npm install -g truffle@next
  • Then change truffle-config.js to point to the RPC endpoint
  • Then use truffle deploy to deploy
@lrettig
Copy link
Member

lrettig commented Nov 14, 2018

Getting the following compile error:

> truffle migrate --network staging
Error parsing sentinel-governance/contracts/DummySentinel.sol: ParsedContract.sol:12:46: ParserError: Expected ',' but got identifier
    function validateAndMeter(bytes calldata input) external pure returns (bytes memory output) {
                                             ^---^
Compilation failed. See above.

@axic
Copy link
Member Author

axic commented Nov 14, 2018

You are using truffle 4.x.

@lrettig
Copy link
Member

lrettig commented Nov 14, 2018

Nope:

~/eth/sentinel-governance> truffle version
Truffle v5.0.0-beta.1 (core: 5.0.0-beta.1)
Solidity v0.4.25 (solc-js)

@axic
Copy link
Member Author

axic commented Nov 15, 2018

It has the configuration to download Solidity 0.5.0 and that instruction is only picked up by truffle 5.

The code is only compiling under Solidity 0.5.0.

If you don't see "Downloading compiler..." then you have a wrong truffle version.

Make sure to reinstall truffle@next.

@lrettig
Copy link
Member

lrettig commented Nov 15, 2018

Reinstalled truffle. It's not installing solc 0.5.0:

> npm un -g truffle
removed 1 package in 1.903s
> npm i -g truffle@next
/Users/lanerettig/.nvm/versions/node/v11.0.0/bin/truffle -> /Users/lanerettig/.nvm/versions/node/v11.0.0/lib/node_modules/truffle/build/cli.bundled.js
+ truffle@5.0.0-next.15
added 81 packages from 311 contributors in 61.912s
> truffle version
Truffle v5.0.0-next.15 (core: 5.0.0-beta.1)
Solidity v0.4.25 (solc-js)
Node v11.0.0
> truffle deploy --network staging
Error parsing /Users/lanerettig/wip/eth/sentinel-governance/contracts/DummySentinel.sol: ParsedContract.sol:12:46: ParserError: Expected ',' but got identifier
    function validateAndMeter(bytes calldata input) external pure returns (bytes memory output) {
                                             ^---^
Compilation failed. See above.
Truffle v5.0.0-next.15 (core: 5.0.0-beta.1)
Solidity v0.4.25 (solc-js)
Node v11.0.0

@axic
Copy link
Member Author

axic commented Nov 15, 2018

Weird, it is working here :(

Will post some console output in a while. One difference is I'm using node 8, but that should cause any difference..

Unfortunately the code won't compile with 0.4.25.

@axic
Copy link
Member Author

axic commented Nov 15, 2018

It seems the very last truffle beta broke. I had an alpha, which was working.

@axic axic removed this from To do in Public testnet (1st milestone) Nov 15, 2018
@axic axic added this to To do in Public testnet (2nd milestone) via automation Nov 15, 2018
@axic
Copy link
Member Author

axic commented Dec 4, 2018

With latest truffle nightly it works again:

  • truffle@5.0.0-next.18

This is what I have:

$ truffle version
Truffle v5.0.0-next.18 (core: 5.0.0-beta.2)
Solidity v0.5.0 (solc-js)
Node v8.2.1

@axic
Copy link
Member Author

axic commented Dec 4, 2018

Updated the repository, it works now with latest nightly of Truffle and the Solidity 0.5.1 releas.e

@jwasinger jwasinger self-assigned this Dec 8, 2018
@jwasinger
Copy link
Contributor

I'll give this a go tomorrow.

@axic
Copy link
Member Author

axic commented Jan 4, 2019

@jwasinger what is the progress on this?

@hugo-dc
Copy link
Member

hugo-dc commented Jan 30, 2019

@axic please take a look at the deployed contract: http://ewasm.ethereum.org/explorer/account/0x793a8d040319253446F90D072D47e95719700026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants