Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jQuery tablesorter plugin to v2 #1666

Merged
merged 8 commits into from Nov 21, 2023

Conversation

jchorl
Copy link
Contributor

@jchorl jchorl commented Apr 9, 2022

Updates tablesorter plugin.

JS min file downloaded from: https://mottie.github.io/tablesorter/docs/#Download

I updated the CSS to cooporate with the new version. I don't know how best to identify incompatibilities/regressions. It looked good to me?

Why? The new version can read default sort data annotated as html data attributes on tables. See the second example here. This means we can work into the multiqc table python logic to slurp configs on initial sort and annotate per-table.

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md has been updated

@vladsavelyev
Copy link
Member

vladsavelyev commented Nov 20, 2023

Hey @jchorl, just getting here through the backlog. Happy to merge (looks like the library wasn't updated since then, so you have still the latest version here!)

But I'm not sure I'm following the justification 🤔 Could you add more detail on what you had in mind, if you recall? Is there a use case where we might need to pass that initial sort config? UPD: ah, here it is, in the next RP 😅 #1666

@vladsavelyev vladsavelyev added the awaits-review Awaiting final review and merge. label Nov 20, 2023
@vladsavelyev vladsavelyev changed the title upgrade jquery tablesorter plugin Upgrade jQuery tablesorter plugin to v2 Nov 20, 2023
@jchorl
Copy link
Contributor Author

jchorl commented Nov 20, 2023

Yeah, for what it's worth, we've been cherry-picking these commits and using them for a while, and it's been working well.

@vladsavelyev vladsavelyev self-requested a review November 21, 2023 13:20
This reverts commit 61c8d48.
@vladsavelyev vladsavelyev merged commit fff441a into MultiQC:master Nov 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-review Awaiting final review and merge. core: front end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants