New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make read and write locks useful #15
Conversation
Thanks for bringing up your concerns and starting the PR! Your suggestions make sense, as locked operations certainly would require some manual sanitization/encryption on the users end. This was not prior since it wasn't something I needed for my use case (I only cared about basic primitives most of the time), but would be nice for other's. PR looks good to me so far, be sure to lint and add test cases too :) |
Great, then I will do the same for the remaining functions, document the changes, and see that the pipeline passes. One question still: |
That sounds good! It looks like |
Could you look at the changes once more? From my side, the changes are good to go, since the previous tests also test the new code. |
This does not hurt but allows moving variables from the closure
Thanks @plainerman for your contributions! The refactoring to lock acquisition and passing in a callback all make sense to me, and am also grateful for getting the Appreciate all the help with this project! |
Thank you very much for merging this so quickly! |
This PR would close #14. It servers as a proposal to discuss the direction we should go to solve this problem. If this is the way we want to go, I can extend it to the remaining useful functions and we can merge the PR.