Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GeometryInfo as preparation for simplex support #104

Open
nfehn opened this issue Dec 2, 2021 · 3 comments
Open

Remove GeometryInfo as preparation for simplex support #104

nfehn opened this issue Dec 2, 2021 · 3 comments
Labels
simplex simplicial elements

Comments

@nfehn
Copy link
Member

nfehn commented Dec 2, 2021

No description provided.

@nfehn nfehn added refactoring Code changes that do not impact functionality deal.II update Changes due to updates in deal.II labels Dec 2, 2021
@peterrum
Copy link
Member

peterrum commented Dec 6, 2021

Remaining instances of GeometryInfo in include/ are:

GeometryInfo<dim>::project_to_unit_cell(cell_and_point.second));

Quadrature<dim> const quadrature(GeometryInfo<dim>::project_to_unit_cell(point_in_ref_coord));

since these two functions are not supported by ReferenceCell. The usage of these function calls could be eliminated by the usage of the functions VectorTools::point_values() as proposed by #107 (comment) and/or by adding asserts as proposed by #107 (comment).

@nfehn
Copy link
Member Author

nfehn commented Jan 28, 2022

deal.II issue dealii/dealii#13308 should be resolved first.

@nfehn
Copy link
Member Author

nfehn commented Mar 15, 2022

Note that there are other occurrences of GeometryInfo in the applications directory.

@nfehn nfehn added simplex simplicial elements and removed refactoring Code changes that do not impact functionality deal.II update Changes due to updates in deal.II labels Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
simplex simplicial elements
Projects
None yet
Development

No branches or pull requests

2 participants