How to deal with unused function parameters

[bugrahantemur]

Something I want to point out is how we deal with unused function parameters:

• Sometimes we use the (void) variable style, and in some places, we even specify a default value for an unused variable, which does not make much sense. I know that using default parameters in virtual functions is generally not a good idea, but if the base class from deal.II already has it, there is nothing we can do about it,

• and sometimes we comment out the variable name like unsigned int /*variable*/.

Originally posted by @btemuer in #421 (comment)

[nfehn]

I personally like the (void) variable style more than just leaving out the parameter. The comment-style is a mixture in the sense that one can still see the name of the variable but does not need to write an additional line of code (void) variable.

[richardschu]

I vote for the (void) variable style, providing a default value in such a case is useful in case one wants to call the function completely omitting the (anyways not needed) variable ... so I can see the point of doing that. Is it pretty? - guess not 🥲