Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlobalCoarsening Multigrid is not robust w.r.t. interior penalty parameter for quad/hex elements #452

Closed
nfehn opened this issue May 25, 2023 · 6 comments
Labels
bug Something isn't working multigrid Multigrid implementation

Comments

@nfehn
Copy link
Member

nfehn commented May 25, 2023

GlobalCoarsening Multigrid is not robust w.r.t. interior penalty parameter for quad/hex elements. For quad/hex, no difference is seen between Distributed/FullyDistributed triangulations.

In contrast, local smoothing MG is robust w.r.t. the interior penalty parameter for quad/hex elements.

Hence, we cannot expect robustness w.r.t. the interior penalty parameter for simplex elements, since simplex meshes have to use MultigridVariant::GlobalCoarsening.

I seems as if the global-coarsening transfer contains a bug for the DG->FE transfer either in deal.II or ExaDG.

The test case is poisson/sine with degree=5 and refine=2 (using a cph-MG strategy).

@peterrum @kronbichler @necioglu

@nfehn nfehn added bug Something isn't working multigrid Multigrid implementation labels May 25, 2023
@peterrum
Copy link
Member

@kronbichler
Copy link
Contributor

This is, as far as I can see, the same bug as in #453 and hopefully fixed by dealii/dealii#15288. One might wonder why that particular bug resulted in increasing iteration counts for higher penalty parameters. The reason is that forgetting to clear the vector means that the content present at restriction gets added into the result of prolongation, so the bigger the penalty parameter, the bigger the residual, and the bigger the (wrong) contribution added to the solution after prolongation. It is surprising that the solver still converged for larger penalty parameters, because the operator is non-symmetric. For small penalty factors and in 3D, it would not matter too much because then the residual is small.

I think we should add the Poisson sine test, run with both local smoothing and global coarsening multigrid, to the tests of ExaDG, to avoid having the same problem unnoticed for so long again.

@nfehn
Copy link
Member Author

nfehn commented Jun 1, 2023

I can report that global-coarsening MG now (i.e. with the changes from dealii/dealii#15288) seems to be robust w.r.t. the interior penalty parameter for quad/hex.

Hence, this issue can be closed once the PR in dealii is merged.

@kronbichler
Copy link
Contributor

Just to be sure, can you confirm that the iteration count is low (around 5), and thus better for global coarsening, than with local smoothing from #453?

@nfehn
Copy link
Member Author

nfehn commented Jun 1, 2023

Yes, it is around 5. So I am happy with these results.

@nfehn
Copy link
Member Author

nfehn commented Jun 1, 2023

The dealii PR has been merged, so I am closing this issue.

@nfehn nfehn closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working multigrid Multigrid implementation
Projects
None yet
Development

No branches or pull requests

3 participants