Accept Meta class inside entity models to override datastore.Client instance params #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exageraldo
commented
Nov 2, 2021
Comment on lines
-104
to
-110
| @staticmethod | ||
| def _to_camel_case(key: str) -> str: | ||
| splited_key = key.split('_') | ||
| return splited_key[0] + ''.join( | ||
| [x.title() for x in splited_key[1:]] | ||
| ) | ||
|
|
There was a problem hiding this comment.
we don't need it anymore
Comment on lines
-164
to
-172
| def _mount_google_entity(self, entity_dict: Dict) -> GoogleEntity: | ||
| entity_key = entity_dict.pop("id") | ||
| entity = GoogleEntity(entity_key) | ||
| for key, value in entity_dict.items(): | ||
| key_name = self._convert_property_name(key) | ||
| entity[key_name] = value | ||
|
|
||
| return entity | ||
|
|
noseiquela_orm/client.py
Outdated
Comment on lines
45
to
53
| def _mount_google_entity(self, entity_dict: Dict, key_case: Callable) -> GoogleEntity: | ||
| entity_key = entity_dict.pop("id") | ||
| entity = GoogleEntity(entity_key) | ||
| for key, value in entity_dict.items(): | ||
| key_name = key_case(key) | ||
| entity[key_name] = value | ||
|
|
||
| return entity | ||
|
|
There was a problem hiding this comment.
I moved it here (from "Entity") because I thought the context made more sense.
Comment on lines
+22
to
+28
| project=project, | ||
| namespace=namespace, | ||
| credentials=credentials, | ||
| client_info=(client_info or _CLIENT_INFO), | ||
| client_options=client_options, | ||
| _http=_http, | ||
| _use_grpc=_use_grpc |
There was a problem hiding this comment.
these are the default client settings (from google lib)
Comment on lines
+16
to
+30
| self._process_meta(attrs) | ||
| self._define_datastore_client() | ||
| self._define_case_style(attrs) | ||
| self._mount_query() | ||
|
|
||
| self._partial_key = KeyField( | ||
| entity_kind=self.kind, | ||
| project=self._project, | ||
| namespace=self._namespace | ||
| project=self.project, | ||
| namespace=self.namespace | ||
| ) | ||
|
|
||
| self._handle_properties_validation(attrs) | ||
| self._handle_required_properties(attrs) | ||
| self._handle_properties_default_value(attrs) | ||
| self._handle_parent_key(attrs) |
There was a problem hiding this comment.
I've broken the steps/processes into functions, to make it easier to understand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so it overwrites only for that model