Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Preferences shortcuts to the player #746

Closed
phalgunlolur opened this issue Mar 15, 2021 · 17 comments
Closed

Add Preferences shortcuts to the player #746

phalgunlolur opened this issue Mar 15, 2021 · 17 comments

Comments

@phalgunlolur
Copy link

I was wondering if it was possible to add shortcuts from the preferences to the main player. For example, I'd like to 'Disallow playing new tracks when another track is playing' when I am actively DJing. I'd love to actively add a shortcut to the main player, on the bottom line where all it seems to do currently is display 'x songs showing, yzzx in collection' on the bottom right

As a sidenote, is it possible to disable that line or change what is displayed on that particular line?

This might also help with another issue I raised in the past (#708) about actively be able to change the delay between songs. If I can add a shortcut to the main player, I can easily a delay time in (milli)seconds and change it as I DJ

Environment

  • Operating System and version: Windows 10
  • Exaile Version: 4.0.2
    GStreamer: 1.16.0
    GTK+: 3.24.8
    GTK+ theme: Adwaita
    Locale: English_United States 1252
    Mutagen: 1.40.0
    PyGObject: 3.32.1
    Python: 2.7.16
@sjohannes
Copy link
Member

There's no mechanism to do this, especially not in a generic way, but it wouldn't be difficult to write a plugin that just adds this for particular config items.

@phalgunlolur
Copy link
Author

oooh, that sounds great. Also, any comments on configuring/ getting rid of what is displayed on the bottom line?

@luzip665
Copy link
Contributor

I would like to try to implement.

My preferred shortcuts are:

  • Queue tracks by default instead of playing them
  • Disallow playing new tracks when another track is playing
  • Remove track from queue upon playback
  • Automatically advance to the next track
  • Delay between tracks (ms)

Any further ideas?

@luzip665
Copy link
Contributor

luzip665 commented Apr 23, 2021

quickbuttons.tar.gz

You can try this plugin.
It adds some buttons and a spinner on the bottom line of the playlist.
The spinner sets the delay between tracks in seconds.

This was referenced Apr 23, 2021
@phalgunlolur
Copy link
Author

Hi @luzip665

I tried installing this plugin but I'm unable to enable it. I get the following error - invalid syntax (C:\Users\phalg\AppData\Local\exaile\plugins\quickbuttons_init_.py, line 77)

I looked up the code and it seems to be this line - def _on_option_set(self, event_name, event_source, option: str) -> None:

@luzip665
Copy link
Contributor

Hi

which python version is installed?
Type hinting came with Python 3.5. Exaile (at least 4.1.1) is supposed to use Python 3.6.

But btw there was a bug in handling the default settings.
quickbuttons-0.2.tar.gz

@phalgunlolur
Copy link
Author

I'm using the windows build - 4.0.2, so it comes with Python 2.7. I'm leaving my system details below:

Operating System and version: Windows 10
Exaile Version: 4.0.2
GStreamer: 1.16.0
GTK+: 3.24.8
GTK+ theme: Adwaita
Locale: English_United States 1252
Mutagen: 1.40.0
PyGObject: 3.32.1
Python: 2.7.16

@luzip665
Copy link
Contributor

luzip665 commented Jun 8, 2021

Can you update?

@phalgunlolur
Copy link
Author

I just did. Didn't realise there was an updated version of Exaile out.

I noticed a small non-performance bug. The spinner(?) where I add the delay is excellent and exactly what I've been looking for. Only thing I would change there is the pop-out text. It currently says the delay is in ms, where as it is actually in seconds!

Is it also possible to add an EQ button there? The only other buttons I can think of is selecting the audio devices for the main playback and preview!

@luzip665
Copy link
Contributor

It seems quite impossible to me to open the equalizer window from a button.

So, for now I only changed the label.
quickbuttons-0.3.tar.gz

@luzip665
Copy link
Contributor

luzip665 commented Aug 3, 2021

Finally I got the equalizer button.
quickbuttons-0.4.tar.gz

@luzip665
Copy link
Contributor

Hello,

I think this can be closed after merging of #755

@phalgunlolur
Copy link
Author

Great. I was wondering if it possible to add a shortcut to select a source for the output audio and the preview device directly too. I'll check out the equalizer button later tonight! Thanks for adding it!

@virtuald
Copy link
Member

Closing this issue for now. @phalgunlolur opened #775 for the feature you just requested.

@phalgunlolur
Copy link
Author

Hi @luzip665,

I downloaded your plugin version 0.4 but sadly, I'm unable to install it. I get an error as follows:

'Plugin archive contains an unsafe path'

image

Also, I realised there is no way for me to uninstall a plugin, apart from disabling it. Am I missing something?

@luzip665
Copy link
Contributor

quickbuttons-0.4.1.tar.gz
Corrected.

But Uninstallation is an issue. Right now you can only just remove the plugin in the exaile data dir.

@phalgunlolur
Copy link
Author

Still says unsafe path for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants