Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve state management #35

Closed
Tracked by #38
ExalFabu opened this issue Jul 9, 2022 · 1 comment
Closed
Tracked by #38

Improve state management #35

ExalFabu opened this issue Jul 9, 2022 · 1 comment
Labels
enhancement New feature or request
Projects
V2
Milestone
v2

Comments

@ExalFabu
Copy link
Owner

ExalFabu commented Jul 9, 2022

How it is now

Currently all I've done to make the website work is "Lifting the state up".
Why? Because I didn't know any better at the time, I knew it was messy and wrong but the time was not a friend and I just did it.

How i imagine the correct way is

After a bit of research i think the correct way would've been to use Redux
Creating a single store containing all the state, divided in slices.

Todo after #34
@ExalFabu ExalFabu added the enhancement New feature or request label Jul 9, 2022
@ExalFabu ExalFabu added this to the v2 milestone Jul 9, 2022
@ExalFabu ExalFabu added this to To do in V2 via automation Jul 9, 2022
This was referenced Jul 14, 2022
Closed
Merged
@ExalFabu
Copy link
Owner Author

Closed by #36

V2 automation moved this from To do to Done Jul 16, 2022
@ExalFabu ExalFabu mentioned this issue Jul 16, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
V2
Done
Milestone
v2
Development

No branches or pull requests
1 participant
@ExalFabu