Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specifying explicit type information for AbstractTronMatrix #10

Closed
youngdae opened this issue Dec 17, 2020 · 0 comments · Fixed by #16
Closed

Specifying explicit type information for AbstractTronMatrix #10

youngdae opened this issue Dec 17, 2020 · 0 comments · Fixed by #16

Comments

@youngdae
Copy link
Member

The original code allowed us to explicitly specify the data type to use for AbstractVector. But this doesn't allow us to specify Matrix type, since we couldn't extract only the data type without its dimensional information. Currently, we removed type specification, but we may want to allow it again at some point for performance.

https://github.com/exanauts/ExaTron/blob/01fad388785a7b1f4a2688a3d692b86cadbd3d19/src/driver.jl#L5-L7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix type inference exanauts/ExaTron.jl
1 participant
@youngdae