#84: Added Exasol SQL statement builder #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morazow
changed the title
Codecov Report
@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 94.59% 95.76% +1.17%
==========================================
Files 10 11 +1
Lines 407 425 +18
Branches 53 48 -5
==========================================
+ Hits 385 407 +22
+ Misses 22 18 -4
Continue to review full report at Codecov.
|
jakobbraun
suggested changes
Mar 2, 2021
| assert(result === Set((1, "Berlin"))) | ||
| test("returns dataframe with greater than filter") { | ||
| val df = getDataFrame().filter($"id" > 2).collect() | ||
| assert(df.map(r => r.getString(1)) === Seq("Portugal")) |
There was a problem hiding this comment.
Maybe you should also test that the predicate was really pushed down. (For example by checking the database logs)
(just an idea; not sure if required / makes sense)
There was a problem hiding this comment.
Yes, it is tested in enricher class.
This is before sending the query to the Exasol.
For example:
val df = spark.read
.option("query", "SELECT * FROM people")
.select("name", "surname")
.filter($"id" > 10)
Should send the modified query to Exasol with column selection and where clauses:
SELECT "name", "surname" FROM people WHERE id > 10
Co-authored-by: jakobbraun <jakob.braun@posteo.de>
jakobbraun
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14
Fixes #39
Fixes #84