[Closes #505] Fix child actor width and height calculations to take into account parent scaling #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…count global scale to fix debug drawing and bounding boxes
kamranayub
added
the
bug
|
Thanks for fixing this! The pull request title is currently 96 characters long, almost double the maximum length of a commit title. Part of this length could be reduced by removing the [Closes #issue_num] prefix, since that information is already conveyed via body of the commit message in the pull request template. |
|
Looks good |
!
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #505
Context
Child actors were not properly taking into account parent(s) scale when calculating their world width and height, so the bounding boxes and unit circle were not properly scaled/drawn.
Debug draw was compensating for previous world coord calculation (that has been fixed), so removed the canvas context transformations.
Proposed Changes:
Actor.getWidth()andActor.getHeight()to take into account global scale