Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File has changes immediately after opening the file #129

Open
fultonm opened this issue Mar 26, 2024 · 5 comments
Open

File has changes immediately after opening the file #129

fultonm opened this issue Mar 26, 2024 · 5 comments

Comments

@fultonm
Copy link
Contributor

fultonm commented Mar 26, 2024

After opening an excalidraw file in VsCode, the file always has changes even if the file has not really been touched yet.

Short screen recording demonstrating the behavior: https://1drv.ms/v/s!AiSCz54h8oiP2DWiRl2ThvtWDyzw?e=G9KR5u

I believe this issue starts to occur when objects are grouped. Without grouping, the file doesn't have changes immediately after opening.

This makes it difficult to know which files have actually been modified, and also creates some anxiety about clicking save/discard changes. Since I am not sure if the file has been ghost-modified from this bug or if the file really had changes.

To figure out what changes there were, I initialized a git repository, and found the version, versionNonce, and updated fields were all modified.

So a potential fix could have the extension wait until the file has been modified by the user before changing these fields.

@fultonm
Copy link
Contributor Author

fultonm commented Apr 3, 2024

Is this a known issue?

Can others reproduce?

@Enzo-PVsyst
Copy link

Hello,

I have the same thing happening on my end.

I just created an folder with some .excalidraw files, and when opening them in VScode they appear with changes.

Is there any workaround ?

@fultonm
Copy link
Contributor Author

fultonm commented Apr 24, 2024

I think I noticed Excalidraw for web also does this. So this may be an upstream issue.

can anyone confirm?

@asinyagin
Copy link

I have the same behavior. Excalidraw changes fields version, versionNonce, updated of each element. It's hard to read diff of files because of these changes.

@lyrixderaven
Copy link

I have exactly the same issue; as soon as I've opened a file it immediately presents with changes; diffing the raw text source shows precisely the fields mentioned by @asinyagin have changed. Any idea on how to resolve this?

We'd like to use Excalidraw extensively for a variety of visualization tasks, and share progress via git, but this problem leads to lots of merge issues due to committing files and changes that have not actually been changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants