toggling the eraser should switch back to the previous tool instead of the select tool

[zsviczian]

Toggling the eraser should switch back to the previous tool (i.e. the one before clicking eraser) instead of switching to the select tool. You can configure the stylus button to toggle the eraser. If toggling would switch to the original tool (e.g. freedraw) instead of the select tool, that would remove friction from the workflow.

[dwelle]

Good idea.

Our recent refactor of appState.elementType → appState.activeTool (#4968) will come in handy as we can put all these state in there.

[zsviczian]

@dwelle so your suggestion is to extend activeTool something like this:

activeTool: { 
  type: typeof SHAPES[number]["value"] | "eraser",
  previousTool?: typeof SHAPES[number]["value"] | "eraser"
};

Right now I can only think of the eraser toggle use case. Should this be eraser specific? Then instead of previousTool something like eraserToggleWithType might be a better name.

[dwelle]

IMO it doesn't matter much, but yes, we can be more clear. eraserPreviousTool/eraserPreviousType?