Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image button not working on iPad (but still works on Android) #5036

Closed
zsviczian opened this issue Apr 13, 2022 · 4 comments · Fixed by #5038
Closed

Add image button not working on iPad (but still works on Android) #5036

zsviczian opened this issue Apr 13, 2022 · 4 comments · Fixed by #5038

Comments

@zsviczian
Copy link
Collaborator

Pressing the add image button (9) activates the Image Element Properties on the left, but the chose-image dialog does not come up on iPad OS.

09A528FF-FBCF-490D-8867-290D09BDCE2B
@dwelle
Copy link
Member

dwelle commented Apr 14, 2022

(please let it not be another legacy-fs race condition!)

@dwelle
Copy link
Member

dwelle commented Apr 14, 2022

Also ensure you're on latest. There was a 1-2 day period where it was broken a while back.

@dwelle
Copy link
Member

dwelle commented Apr 14, 2022

Ok, can repro. It was introduced in #4955

@zsviczian
Copy link
Collaborator Author

So I see where the issue is. Are you working on the fix, or should I create a PR?

@zsviczian zsviczian mentioned this issue Apr 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add image button not working on iPad excalidraw/excalidraw
2 participants
@dwelle @zsviczian