Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exportToSvg() does not respect window.EXCALIDRAW_ASSET_PATH #5063

Closed
thfrei opened this issue Apr 18, 2022 · 4 comments · Fixed by #5065
Closed

exportToSvg() does not respect window.EXCALIDRAW_ASSET_PATH #5063

thfrei opened this issue Apr 18, 2022 · 4 comments · Fixed by #5065
Labels
bug Something isn't working package:excalidraw @excalidraw/excalidraw

Comments

@thfrei
Copy link

thfrei commented Apr 18, 2022

Dear excalidraw team.

First of all, thank you for your great efforts. I am working on integrating the excalidraw library into the trilium note app (zadam/trilium#2798). Since trilium is mainly self-hosted, it is important to self-host all assets.

After setting window.EXCALIDRAW_ASSET_PATH it seemed to solve the issue when using the react version. However, since we use exportToSvg() to save an SVG-image, I found, that some assets are still loaded from a 3rd party. This time not unpkg.com, but excalidraw.com.

I did not have time to do a solution, but I found the lines that indicates the problem.

Thank you for your time.

Best regards
Thomas

PS: Of course, we could just string-replace the url of the fonts, but it looked like a minor bug to me.

@ad1992
Copy link
Member

ad1992 commented Apr 19, 2022

Hi @thfrei 👋🏻, you are right, the fonts path is not using the asset path when exporting. We will look into this.

@ad1992 ad1992 added bug Something isn't working package:excalidraw @excalidraw/excalidraw labels Apr 19, 2022
@thfrei
Copy link
Author

thfrei commented Apr 29, 2022

@ad1992 Thank you very much! 💐

@ad1992
Copy link
Member

ad1992 commented Apr 29, 2022

@thfrei you will need to use @excalidraw/excalidraw-next if you want this change, we will be soon releasing it in the official version as well.

@bric3
Copy link

bric3 commented Jan 9, 2024

Opened an new issue instead of commenting here #7543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package:excalidraw @excalidraw/excalidraw
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants