Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android Navbar bp-action-overflow shows up for >= 3 icons #103

Closed
Goltergaul opened this issue Aug 19, 2014 · 1 comment
Closed

Android Navbar bp-action-overflow shows up for >= 3 icons #103

Goltergaul opened this issue Aug 19, 2014 · 1 comment

Comments

@Goltergaul
Copy link

Hi the android navbar shows that submenu as soon as the navbar contains more then 3 action-icons.
This results in 2 icons beeing displayed and the dropdown with only one item in it. I think it would be better if the submenu would only appear for >= 4 icons. Why do I need a submenu if there is only one option in it? It would be better to just display the icon instead. Unfortunately this is hardcoded into the source of bradypodion so there is no chance to change it

@boennemann
Copy link
Contributor

Hey @Goltergaul,
that's indeed a bit illogical.

Do you think you can send a PR?
https://github.com/excellenteasy/bradypodion/blob/master/src/scripts/directives/navbar.js#L198

Best,
Stephan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants