We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
You can continue the conversation there. Go to discussion →
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi, mailer method is defined as an underscored class name if the method option wasn't provided
method
noticed/lib/noticed/delivery_methods/email.rb
Lines 36 to 43 in df561f3
But if I put my notification class to a module the result string will contain the name of that module as a prefix.
Employees::NotifyAboutNewOrder.name.underscore #=> "employees/notify_about_new_order"
I think it is appropriate to pre-demodulize a class name here.
The text was updated successfully, but these errors were encountered:
Makes sense to me. Do you want to submit a PR for that?
Sorry, something went wrong.
@excid3 hi! What you think about @StanisLove PR?
Successfully merging a pull request may close this issue.
Hi, mailer method is defined as an underscored class name if the
method
option wasn't providednoticed/lib/noticed/delivery_methods/email.rb
Lines 36 to 43 in df561f3
But if I put my notification class to a module the result string will contain the name of that module as a prefix.
I think it is appropriate to pre-demodulize a class name here.
The text was updated successfully, but these errors were encountered: