Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Exclude the right border of the injection time interval #1885

Merged
merged 1 commit into from May 21, 2014
Merged

Conversation

nremond
Copy link
Contributor

@nremond nremond commented May 21, 2014

This PR fixes some injection rate computing bugs.

@@ -106,20 +106,24 @@ case class RampRateInjection(r1: Double, r2: Double, duration: FiniteDuration) e
}

/**
* Inject users thru separated steps until reaching the total amount of users
* Inject users thru separated steps until reaching the closest possible amount of total users.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

through

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean "thru" => "through"? http://english.stackexchange.com/a/91782, same, no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So yes, thru is some sort of slang or jargon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bro

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:p
Corrected that.

On Wed, May 21, 2014 at 3:05 PM, Stephane Landelle <notifications@github.com

wrote:

In
gatling-core/src/main/scala/io/gatling/core/controller/inject/InjectionStep.scala:

@@ -106,20 +106,24 @@ case class RampRateInjection(r1: Double, r2: Double, duration: FiniteDuration) e
}

/**

  • * Inject users thru separated steps until reaching the total amount of users
  • * Inject users thru separated steps until reaching the closest possible amount of total users.

bro


Reply to this email directly or view it on GitHubhttps://github.com//pull/1885/files#r12894342
.

…pping on border when chaining.

Limit the injection starting times to the millisec to avoid flooding the scheduler
nremond added a commit that referenced this pull request May 21, 2014
Exclude the right border of the injection time interval
@nremond nremond merged commit aaa7e80 into master May 21, 2014
@nremond nremond deleted the inject branch May 21, 2014 14:54
@slandelle slandelle added this to the 2.0.0-RC1 milestone May 21, 2014
@slandelle slandelle changed the title Exclude the right border of the injection time interval Core: Exclude the right border of the injection time interval May 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants