Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies to work on flutter 2.2.0 #25

Merged
merged 2 commits into from Jun 9, 2021

Conversation

aumb
Copy link
Contributor

@aumb aumb commented Jun 9, 2021

Hey!

I noticed the app was not working on the newest version of flutter. Here are the changes I made:

  • I updated most of the dependencies to the latest version, and did the necessary changes for depreciated usages.

  • I changed the mock package from Mockito to Mocktail (https://pub.dev/packages/mocktail)

  • I upgrade the gradle version

  • I set the IOS platform to 9 for sqflite to work

Please let me know if there's something you need me to change 馃挋

@vedartm
Copy link
Owner

vedartm commented Jun 9, 2021

Hi @aumb. Really appreciate you making this PR. Can you please fix build workflow. I am assuming the issue is the flutter version used in build.yaml

@aumb
Copy link
Contributor Author

aumb commented Jun 9, 2021

Hi @aumb. Really appreciate you making this PR. Can you please fix build workflow. I am assuming the issue is the flutter version used in build.yaml

Yes sure on it!

I can migrate the application to null safety if you'd like as well.

@vedartm
Copy link
Owner

vedartm commented Jun 9, 2021

Migrating to null safety would be great @aumb

@aumb
Copy link
Contributor Author

aumb commented Jun 9, 2021

Migrating to null safety would be great @aumb

Okay will migrate as soon as this is merged so i can worked based on this. I'll open another pull request for null safety if this is all ok with you.

@vedartm vedartm merged commit e9d2cd4 into vedartm:develop Jun 9, 2021
@vedartm
Copy link
Owner

vedartm commented Jun 9, 2021

Thanks for contributing @aumb 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants