Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Refactored #28

Merged
merged 4 commits into from Sep 23, 2021
Merged

♻️ Refactored #28

merged 4 commits into from Sep 23, 2021

Conversation

elias8
Copy link
Contributor

@elias8 elias8 commented Sep 6, 2021

  • Use functional_enum for types which can be replaced by enums. this decreases the amount of code by a lot btw
  • Use JsonConverter for converting types instead of using static methods
  • Remove deprecated abstract keyword for freezed classes

Copy link
Owner

@vedartm vedartm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate you making this PR @elias8 👏🏻

@vedartm vedartm merged commit afce20c into vedartm:develop Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants