Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

author names disappear in dark theme #195

Closed
raphaelquast opened this issue Nov 30, 2023 · 4 comments
Closed

author names disappear in dark theme #195

raphaelquast opened this issue Nov 30, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@raphaelquast
Copy link

Description

While trying to make my notebooks more beautiful, I stumbled upon the very nice title-formatting options of MySt...

So I created a title like this:

---
title: A nice title
subject: Tutorial
subtitle: with a neat subtitle
authors:
  - name: The Creator
license: CC-BY-4.0
---

some very important text

Which renders nicely in the "JupyterLab Light" Theme.
image

However, if I switch to the "JupyterLab Dark" Theme, the author-names disappear (I guess the font-color is not properly updated?)
image

@raphaelquast raphaelquast added the bug Something isn't working label Nov 30, 2023
Copy link

welcome bot commented Nov 30, 2023

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@rowanc1
Copy link
Collaborator

rowanc1 commented Nov 30, 2023

Thanks for the report! I think that this should be fixed in the underlying theme components in myst-theme as it is now working well online, for example, toggling dark mode on your content here.

Hoping to get to another release of jupyterlab-myst in the next few weeks and will test this then.

@raphaelquast
Copy link
Author

Nice! Yep, your online example works as expected... Thanks for the quick response!

@agoose77
Copy link
Collaborator

I'm closing this as it's fixed upstream. We'll make a release soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants