Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mermaid now rendered natively by JupyterLab 4.1 and Notebook 7.1 #226

Closed
psychemedia opened this issue Mar 18, 2024 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@psychemedia
Copy link

Description

Jupyterlab-myst originally added the ability to render mermaid diagrams, but the markdown renderer in JupyterLab 4.1/Notebook 7.1 now do this natively: https://jupyterlab.readthedocs.io/en/latest/getting_started/changelog.html#diagrams-in-markdown

The JupyterLite demo seems to be removing jupyterlab-myst with the update to JL4.1/nb7.1 because of a clash between native handling of mermaid diagram descriptions and how jupyterlab-myst handles them:

@psychemedia psychemedia added the bug Something isn't working label Mar 18, 2024
@psychemedia
Copy link
Author

I note that the native (JupyterLab4.1/notebook 7.1) handling follows GFM and uses the syntax:

```mermaid
flowchart LR

A[Hard] -->|Text| B(Round)
```

rather than:

```{mermaid}
flowchart LR

A[Hard] -->|Text| B(Round)
```

@rowanc1
Copy link
Member

rowanc1 commented Apr 24, 2024

image

image

This is fixed in 2.4.0!

@rowanc1 rowanc1 closed this as completed Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants