Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: correct font-sizes (again!) #237

Merged
merged 10 commits into from
Apr 26, 2024
Merged

Conversation

agoose77
Copy link
Collaborator

No description provided.

Copy link
Contributor

Binder 👈 Launch a Binder on branch executablebooks/jupyterlab-myst/agoose77/fix-style-font-size

@agoose77 agoose77 added the bug Something isn't working label Apr 25, 2024
@agoose77
Copy link
Collaborator Author

@rowanc1 can I get a quick sense check on the use of preflight.css vs the tailwind config?

@agoose77
Copy link
Collaborator Author

please update snapshots

@agoose77 agoose77 closed this Apr 25, 2024
@agoose77 agoose77 reopened this Apr 25, 2024
@rowanc1
Copy link
Collaborator

rowanc1 commented Apr 25, 2024

I think overall this makes sense! It would be nice to have a typography snapshot to see and predict these changes as well...!

@agoose77
Copy link
Collaborator Author

please update snapshots

@agoose77
Copy link
Collaborator Author

please update snapshots

@agoose77 agoose77 self-assigned this Apr 26, 2024
@agoose77
Copy link
Collaborator Author

please update snapshots

@agoose77 agoose77 enabled auto-merge (squash) April 26, 2024 12:20
@agoose77 agoose77 closed this Apr 26, 2024
auto-merge was automatically disabled April 26, 2024 12:26

Pull request was closed

@agoose77 agoose77 reopened this Apr 26, 2024
@agoose77 agoose77 merged commit 909a575 into main Apr 26, 2024
5 checks passed
@agoose77 agoose77 deleted the agoose77/fix-style-font-size branch April 26, 2024 12:39
@rowanc1
Copy link
Collaborator

rowanc1 commented Apr 26, 2024

New tests/screenshots look awesome. Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants