Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ NEW: General improvements #10

Merged
merged 30 commits into from Nov 22, 2020
Merged

✨ NEW: General improvements #10

merged 30 commits into from Nov 22, 2020

Conversation

rowanc1
Copy link
Member

@rowanc1 rowanc1 commented Nov 20, 2020

There are a number of general improvements and reorganizing that are in this PR as I get back into development. The PR as it stands touches most things as the library is still quite new.

I think it is worth pushing ahead on this and as we move closer to something that covers the basics of myst parsing/setup etc. we can start to move to more targeted commits. Perhaps we should move to a dev branch model? As this isn't really ready for a version bump either?

image

New Features

  • block breaks +metadata +++ {meta:data}
  • inline comments % comment
  • admonitions
  • references to headers ()=
  • figures, num ref and default reference names
  • math and numbered math blocks
  • equation numbers

Still lacking

  • The extension of new directives especially is pretty confusing, and it would be better to have more separation in the file structures as knowing which file to jump into is hard at the moment.
  • Am not parsing yaml Parsing directive options #8 although I did get a start at the other options. These are not typed or checked at all against directives, which they should be.
  • There are a few too many passes on numbering, I think that needs to be simplified and centralized. I have started a pattern of putting the target on the token.meta.target but haven't pushed it all the way through yet.

@choldgraf
Copy link
Member

I love it - the sample page looks much nicer and the styling looks really good 👍

Couple quick thoughts:

  1. Personally I'd just merge this into master and keep iterating that way. We designate this repo as "pre-alpha" which IMO means that users can't expect any kind of continuity of functionality or API.
  2. I like the red background for refs that don't resolve, though I worry that this may confuse some folks who are referencing a different page. Not saying it's a dealbreaker for the red highlighting, but wanted to note it.
  3. I wonder if we could build some simple Sphinx docs for this package? The index.html could be hosted along with the Sphinx package if we wish, no? I guess we're gonna run into the same issues as using local thebe in docs thebe#298 though :-/

@rowanc1
Copy link
Member Author

rowanc1 commented Nov 21, 2020

That all sounds good. In the middle of a bit of refactoring at the moment. Will push through on that and then merge it in.

I have changed it to an error class just now - so can play with the styling. Right now the references aren't well exposed, so difficult to create the external/cross-page refs. I will be working on that too. 👍

Had the same thoughts for the sphinx docs, can look into some alternative ways of building the docs. Maybe take the build onto gh-actions and host on gh-pages? Not sure.

@rowanc1 rowanc1 marked this pull request as ready for review November 22, 2020 00:56
@rowanc1 rowanc1 merged commit ca50f68 into master Nov 22, 2020
@rowanc1 rowanc1 deleted the getting-started branch November 22, 2020 00:57
@choldgraf
Copy link
Member

🚀

rowanc1 pushed a commit that referenced this pull request Oct 28, 2022
* Add ris to reference
* Add RIS type
* Change FormatOptions to Union type
* Format
* Remove format form ReferenceForamtOptions
rowanc1 pushed a commit that referenced this pull request Oct 28, 2022
🕰  always take latest reference
rowanc1 added a commit that referenced this pull request Oct 28, 2022
allow suffix to be configured for caption label
rowanc1 added a commit that referenced this pull request Oct 28, 2022
* Add copy icon to code block
* Use green to show code copied
* Update the look of the icon button
* Use HeroIcon icon component
* Use port 5001 for dev server
* Fix react key error on paragraph node

Co-authored-by: Rowan Cockett <rowanc1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants