New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch up with markdown-it v12.0.4 #110
Conversation
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
==========================================
- Coverage 96.51% 96.51% -0.01%
==========================================
Files 72 72
Lines 3185 3183 -2
==========================================
- Hits 3074 3072 -2
Misses 111 111
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
[12.0.4] - 2020-12-20Fixed
[12.0.3] - 2020-12-07Fixed
[12.0.2] - 2020-10-23Fixed
[12.0.1] - 2020-10-19Fixed
[12.0.0] - 2020-10-14Changed
Fixed
|
I think maybe split this up into a few defined commits, e.g. one for links, one for the table etc? For tables what is the actual difference? are there table syntaxes that were not allowed before or are allowed now? Is there any tests we can add to highlight the difference? |
ah oops, I missed the changes to tables.md (because the diff was collapsed) |
This might be nice to have, but at least I find it hard to motivate myself to do this 😄 I don't mind at all if you take the changes and redo the commit history.
The test cases I re-added show some changes. I think it's a bit hard to argue more about the changes, since previously there was no formal spec that was followed. |
Nice, I merged master to this and as a result there's still a few changes left here that seem like they belong in master. |
From the merge conflicts I noticed a few minor errors that I'm just about to commit |
Comparing to #110 I noticed a few mistaken regressions
A continuation on #109 (based on the branch there). Adds the changes in markdown-it/markdown-it@11.0.1...12.0.4 on top
#109 can be merged first and then this one (to make review easier), or this can be merged directly.