Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape hashes less #104

Closed
hukkin opened this issue Jan 3, 2021 · 2 comments · Fixed by #105
Closed

Escape hashes less #104

hukkin opened this issue Jan 3, 2021 · 2 comments · Fixed by #105
Labels
enhancement New feature or request

Comments

@hukkin
Copy link
Member

hukkin commented Jan 3, 2021

Input:

- Recalculate secondary dependencies between rounds (#378)

Current output:

- Recalculate secondary dependencies between rounds (\#378)

Come up with logic that allows us to escape the hash character # in fewer cases. Only escape if the character would start an ATX heading.

@hukkin hukkin added the enhancement New feature or request label Jan 3, 2021
@hukkin
Copy link
Member Author

hukkin commented Jan 3, 2021

Note: Make a test case to ensure numeric character references (e.g. M) don't break.

@hukkin
Copy link
Member Author

hukkin commented Jan 3, 2021

I think the following should do the trick:

  1. Move escaping from text renderer to paragraph renderer.
  2. Escape first # char of each line if it is only preceded by 0 or more whitespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant