Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement Thoughts #11

Closed
chrisjsewell opened this issue Sep 14, 2020 · 6 comments
Closed

Improvement Thoughts #11

chrisjsewell opened this issue Sep 14, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@chrisjsewell
Copy link
Member

chrisjsewell commented Sep 14, 2020

As discussed in executablebooks/markdown-it-py#10, great work!

A few thoughts off the cuff:

  • use click for CLI, which can also read configuration from a config file (see https://github.com/executablebooks/scss-compile for an example)
  • Plugin system for code block formatting (e.g. black for python blocks)
  • Add tox configuration, for test automation
@chrisjsewell chrisjsewell changed the title Various Improvement Thoughts Improvement Thoughts Sep 14, 2020
@hukkin
Copy link
Member

hukkin commented Sep 15, 2020

Thanks for your thoughts!

I think this is a great idea and should be implemented if we end up having configuration. Currently there is zero configuration, so I'd be hesitant to add a new dependency if argparse can still get the job done just fine.

  • Plugin system for code block formatting (e.g. black for python blocks)

I really like this. I made a separate issue #12

  • Add tox configuration, for test automation

If there is a problem that this would solve, I don't see why not. Currently though we have no sys.version_info checks (meaning all Python versions do pretty much the same stuff), and no dependencies where we would need to test support for more than one major version, so while developing I've found simply running pytest sufficient. CI runs tests on all OS and py versions though.

@chrisjsewell
Copy link
Member Author

If there is a problem that this would solve, I don't see why not

Mainly just for me lol; when jumping around between lots of repositories, its just really helpful to be able to quickly run tox, rather than manually setting-up/initializing new dev environments every time

@chrisjsewell
Copy link
Member Author

Whaay thanks @hukkinj1, welcome to EBP 🥳 (cc @choldgraf @mmcky @AakashGfude).
Think I'll just delete the whole package now 😆

@chrisjsewell chrisjsewell added the enhancement New feature or request label Sep 15, 2020
@hukkin
Copy link
Member

hukkin commented Sep 15, 2020

Think I'll just delete the whole package now

liam

@chrisjsewell
Copy link
Member Author

even if you found me, you would still have to wait a few weeks in quarantine 😆

@hukkin
Copy link
Member

hukkin commented Sep 15, 2020

Oh man, add another two weeks to that after the flight back. It might just not be worth it. You win.

To conclude this ticket: I think there's no immediate action items on this issue, so closing. A tox PR is welcome if someone finds it helpful. Click shouldn't IMO be rushed until it solves a problem (e.g. reading a configuration file).

@hukkin hukkin closed this as completed Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants