Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for links links and titles in block quote attributions #830

Closed
hynek opened this issue Nov 24, 2023 · 9 comments · Fixed by #831
Closed

Allow for links links and titles in block quote attributions #830

hynek opened this issue Nov 24, 2023 · 9 comments · Fixed by #831

Comments

@hynek
Copy link

hynek commented Nov 24, 2023

I would like to use attrs_block attributions for my block quotes but it seems like I can't have a title and a link in there. If I use a Markdown link, it's used verbatim, if I use an HTML link, the attrs line is rendered verbatim.

Ideally it would be a separate attribute:

{attribution="Hyrum Wright", attribution_title="Hyrum's Law" attribution_link="https://www.hyrumslaw.com"}
> With a sufficient number of users of an API, it does not matter what you promise in the contract: all observable behaviors of your system will be depended on by somebody.

would give me:

<blockquote cite="https://www.hyrumslaw.com">
  <p>With a sufficient number of users of an API, it does not matter what you promise in the contract: all observable behaviors of your system will be depended on by somebody.</p>

  <cite>— Hyrum Wright, <a href="https://www.hyrumslaw.com">Hyrum’s Law</a></cite>
</blockquote>
Copy link

welcome bot commented Nov 24, 2023

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@chrisjsewell
Copy link
Member

Heya, see #831, I agree that the attribution should be parsed as MyST

would give me ...

I'm not sure about acheiving this though;
I agree that this looks to be a better HTML representation (like https://developer.mozilla.org/en-US/docs/Web/HTML/Element/blockquote),
but I think it would require changes to the upstream HTML renderer; https://github.com/live-clones/docutils/blob/master/docutils/docutils/writers/_html_base.py

@hynek
Copy link
Author

hynek commented Nov 24, 2023

BTW I'm sorry if I've accidentally circumvented some kind of community process as the message of the bot insinuates. I just clicked "new issue" in the docs and search the issues for "attribution" (and found nothing).

@chrisjsewell
Copy link
Member

as the message of the bot insinuates

Oh no, this just gets fired for every first-time contributor 😄

@hynek
Copy link
Author

hynek commented Nov 24, 2023

Yeah I didn't feel attacked specifically, I'm just seeing mentions of issue templates (I had none) etc. :)

@chrisjsewell
Copy link
Member

@hynek would #831 be sufficient for you at this time?
I could potentially add something like a cite attribute that is "stored" on the block_quote node:

{attribution="Hyrum Wright", cite="https://www.hyrumslaw.com/"}
> With a sufficient number

But, as I mention above, I don't think this would currently propagate to the actual output HTML

@hynek
Copy link
Author

hynek commented Nov 24, 2023

Would #831 mean I can do:

{attribution="Hyrum Wright, [Hyrum’s Law](https://www.hyrumslaw.com>)"}
> With a sufficient number

And get:

<blockquote>
  <p>With a sufficient number…</p>

  <cite>— Hyrum Wright, <a href="https://www.hyrumslaw.com">Hyrum’s Law</a></cite>
</blockquote>

?

I don't care that much about the cite attribute because I don't think anyone is actually using it? I primarily want to be able to have richer citations in the cite tag. :)

@chrisjsewell chrisjsewell linked a pull request Nov 24, 2023 that will close this issue
@chrisjsewell
Copy link
Member

Would #831 mean I can do

yep 👍 see the updated example in https://myst-parser--831.org.readthedocs.build/en/831/syntax/optional.html#attributes

@hynek
Copy link
Author

hynek commented Nov 24, 2023

Well, perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants