Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔗 Add support for github issue previews #91

Merged
merged 1 commit into from
May 15, 2023
Merged

🔗 Add support for github issue previews #91

merged 1 commit into from
May 15, 2023

Conversation

rowanc1
Copy link
Collaborator

@rowanc1 rowanc1 commented May 15, 2023

@rowanc1
Copy link
Collaborator Author

rowanc1 commented May 15, 2023

cc @choldgraf this is the work for the previews we were talking about! I think there is a bunch to improve (I have just skipped over github markdown parsing for the body text). That choice is mainly to keep the JS bundle small, and I think for a preview, it mostly looks ok.

I have picked up on the tags, and have a simple choice to show white or black text on it.

Going to push through and get this out the door and start testing it more! 🚀

@tavin if you have thoughts, always feel free to comment on the PRs and I/we will follow up and fix things (defaulting to ship/show pattern, to move fast, but absolutely open to feedback and fixing things even though a PR is merged!!).

@rowanc1 rowanc1 merged commit 4c9b763 into main May 15, 2023
@rowanc1 rowanc1 deleted the feat/github branch May 15, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant