Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from node to index lookup #52

Merged
merged 1 commit into from Jun 20, 2022
Merged

Move from node to index lookup #52

merged 1 commit into from Jun 20, 2022

Conversation

rowanc1
Copy link
Member

@rowanc1 rowanc1 commented Jun 20, 2022 •
edited

I was running into all sorts of bugs when I was running this on the jupyter-book documentation, this is one of them. I couldn't trace it down, but this seems to be equivalent.

image

@rowanc1 rowanc1 requested a review from fwkoch June 20, 2022 15:09
fwkoch
fwkoch approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@fwkoch fwkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, yeah, this seems fine. findAfter just looks up index from node, so handing it the index is more direct.

@fwkoch fwkoch merged commit f018c32 into main Jun 20, 2022
@fwkoch fwkoch deleted the bug/targets branch June 20, 2022 16:19
rowanc1 added a commit that referenced this pull request Oct 28, 2022
@rowanc1
🚀 Merge pull request #52 from curvenote/feat/start
259027b 
Curvenote Start
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwkoch fwkoch fwkoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rowanc1 @fwkoch