Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AST: Code-cell should be turned into a block with output #439

Open
rowanc1 opened this issue Jun 22, 2023 · 0 comments
Open

AST: Code-cell should be turned into a block with output #439

rowanc1 opened this issue Jun 22, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@rowanc1
Copy link
Member

rowanc1 commented Jun 22, 2023

There is some discussion and notes here:
https://github.com/orgs/executablebooks/discussions/1037

I think this can be done in the code-cell directive (here).

Changing the return of that to a [{type: 'block', children: [code, {type: output, data: []}]] will I think fix the issue. We should make sure this matches the notebook output and have a few tests around this for consistency!

@rowanc1 rowanc1 added the bug Something isn't working label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant