Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom favicons #925

Closed
Tracked by #1002
choldgraf opened this issue Feb 21, 2024 · 6 comments
Closed
Tracked by #1002

Support custom favicons #925

choldgraf opened this issue Feb 21, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@choldgraf
Copy link
Collaborator

Proposal

I'd like to be able to set a custom favicon. Based on the website configuration docs I'd expect the configuration to look something like this:

# See docs at: https://mystmd.org/guide/frontmatter
version: 1
project:
  # title:
  # description:
site:
  template: book-theme
  # title:
  # options:
  #   logo: my_logo.png
       favicon: my_favicon.png
@choldgraf choldgraf added the enhancement New feature or request label Feb 21, 2024
rowanc1 added a commit to jupyter-book/myst-theme that referenced this issue Apr 11, 2024
rowanc1 added a commit that referenced this issue Apr 11, 2024
rowanc1 added a commit to jupyter-book/myst-theme that referenced this issue Apr 11, 2024
rowanc1 added a commit that referenced this issue Apr 11, 2024
@rowanc1
Copy link
Collaborator

rowanc1 commented Apr 11, 2024

It will have to wait for the next mystmd release to work on github pages, but works locally now. ⭐

image

Should also work with svg and png.

@rowanc1 rowanc1 closed this as completed Apr 11, 2024
@choldgraf
Copy link
Collaborator Author

@rowanc1 I think this may still not work on static html-generated sites...is that possible?

@rowanc1
Copy link
Collaborator

rowanc1 commented Apr 11, 2024

Yes! Not until the next release of mystmd (probably in a few days):

It will have to wait for the next mystmd release to work on github pages

@choldgraf
Copy link
Collaborator Author

ohhh I see that's what you meant by "work on github pages"

@lorenzo-rovigatti
Copy link

Thanks for the new feature! I'm commenting just to tell you that in order for the new favicon to show up I had to delete the _build folder content. Maybe it's worth pointing this out somewhere in the docs?

@rowanc1
Copy link
Collaborator

rowanc1 commented Apr 19, 2024

Yes, we don't yet have a notification on the new templates being released. There is a note in the update instructions here:
https://mystmd.org/guide/quickstart

image

We are also tracking the issue here: #854.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants