Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌀 Change to SourceFileKind (from KINDS) #335

Merged
merged 1 commit into from
Mar 30, 2023
Merged

🌀 Change to SourceFileKind (from KINDS) #335

merged 1 commit into from
Mar 30, 2023

Conversation

rowanc1
Copy link
Collaborator

@rowanc1 rowanc1 commented Mar 29, 2023

Move enum to myst-common

@rowanc1 rowanc1 requested a review from fwkoch March 29, 2023 22:24
@rowanc1
Copy link
Collaborator Author

rowanc1 commented Mar 29, 2023

@stevejpurves this should make the kind available to thebe (or that part of the theme), without importing from the CLI.

Copy link
Collaborator

@fwkoch fwkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just moving around and renaming.

GenericNode,
GenericParent,
Citations,
Footnotes,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't need to be used anymore!

rowanc1 added a commit to jupyter-book/myst-theme that referenced this pull request Mar 30, 2023
@rowanc1 rowanc1 merged commit d28b5e9 into main Mar 30, 2023
@rowanc1 rowanc1 deleted the ref/kind branch March 30, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants