Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ•΅πŸ½β€β™€οΈ LaTeX improvements for \ce & listings #429

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

rowanc1
Copy link
Collaborator

@rowanc1 rowanc1 commented Jun 16, 2023

Copy link
Collaborator Author

@rowanc1 rowanc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Would be nice to do a better pass on improving chemical formulas!

"declarationMap": false,
"declarationMap": true,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improvements for local development!

Comment on lines +5 to +11
macro_ce(node, state) {
state.openParagraph();
const value = texToText(getArguments(node, 'group')[0]);
state.addLeaf('chemicalFormula', {
value,
});
return;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really basic, but works!

@rowanc1
Copy link
Collaborator Author

rowanc1 commented Jun 16, 2023

I think we need to increase the test timeout for vitest, right now it is only 5s and that is a bit short to download the tex templates.

@rowanc1 rowanc1 merged commit 2c19d72 into main Jun 19, 2023
3 checks passed
@rowanc1 rowanc1 deleted the feat/tex branch June 19, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant