Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove spurious alt text when using img-background, img-top or img-bottom options #112

Closed
wants to merge 1 commit into from
Closed

fix: Remove spurious alt text when using img-background, img-top or img-bottom options #112

wants to merge 1 commit into from

Conversation

jpmckinney
Copy link
Contributor

@jpmckinney jpmckinney commented Dec 8, 2022 •
edited

closes #111

@welcome
Copy link

welcome bot commented Dec 8, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@chrisjsewell
Copy link
Member

Err, image alt texts are there for accessibility, so I'm not convinced it's trivial to just remove them

@jpmckinney
Copy link
Contributor Author

jpmckinney commented Dec 8, 2022 •
edited

I mean, these texts aren't providing any accessibility. True accessibility would be user-provided text, which is #33 and #108. The current text is just sort of noise to a screen reader. An explicit blank alt attribute is better than noise.

@jpmckinney
Copy link
Contributor Author

Anyway, I'll close in favor of #114.

@jpmckinney jpmckinney closed this Dec 8, 2022
@jpmckinney jpmckinney deleted the 111-remove-spurious-alt-text branch December 8, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

i18n: Spurious (and translatable) alt-text added to cards
2 participants
@jpmckinney @chrisjsewell