Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for FIPS enabled systems #161

Closed
gabor-varga opened this issue Sep 8, 2023 · 1 comment · Fixed by #162
Closed

Add support for FIPS enabled systems #161

gabor-varga opened this issue Sep 8, 2023 · 1 comment · Fixed by #162
Labels
bug Something isn't working

Comments

@gabor-varga
Copy link
Contributor

Describe the bug

context
When using the extension on FIPS-enabled systems, hashlib.md5 fails (update_css_js:70) due to security reasons.

expectation
The hashing should work, independently of FIPS being enabled or not.

bug
The following exception is encountered instead:

Extension error (sphinx_design.extension):
Handler <function update_css_js at 0x7f44aa9b9280> for event 'builder-inited' threw an exception (exception: [digital envelope routines] unsupported)

problem
This is a problem for users generating documentation on these systems.

solutions
Changing the algorithm, or adding usedforsecurity=Flag kwarg seems to solve the issue.

hash = hashlib.md5(content.encode("utf8"), usedforsecurity=False).hexdigest()

or

hash = hashlib.sha256(content.encode("utf8")).hexdigest()

Reproduce the bug

  1. Enable FIPS on your system
  2. Try to generate documentation using sphinx-design
  3. Generation fails

List your environment

Standard python-3.9.

@gabor-varga gabor-varga added the bug Something isn't working label Sep 8, 2023
@welcome
Copy link

welcome bot commented Sep 8, 2023

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant